Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Conversation

@mpeddada1
Copy link
Contributor

To merge into 2.3.x branch. This PR was generated using Protobuf 3.19.6. Source-Link: googleapis/googleapis@853e8a2

@mpeddada1 mpeddada1 requested review from a team as code owners October 11, 2022 20:21
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: container Issues related to the googleapis/java-container API. labels Oct 11, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/AcceleratorConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/AddonsConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/AddonsConfigOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/AuthenticatorGroupsConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/AutoUpgradeOptions.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/AutoprovisioningNodePoolDefaults.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/BinaryAuthorization.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CancelOperationRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CancelOperationRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ClientCertificateConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CloudRunConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/Cluster.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ClusterAutoscaling.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ClusterOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ClusterUpdate.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CompleteIPRotationRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CompleteIPRotationRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ConfigConnectorConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CreateClusterRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CreateClusterRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CreateNodePoolRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/CreateNodePoolRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DailyMaintenanceWindow.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DatabaseEncryption.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DefaultSnatStatus.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DeleteClusterRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DeleteClusterRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DeleteNodePoolRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DeleteNodePoolRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/DnsCacheConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetClusterRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetClusterRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetJSONWebKeysRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetJSONWebKeysResponse.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetNodePoolRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetNodePoolRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetOpenIDConfigRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetOpenIDConfigResponse.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetOperationRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetOperationRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetServerConfigRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/GetServerConfigRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/HorizontalPodAutoscaling.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/HttpLoadBalancing.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/IPAllocationPolicy.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/IPAllocationPolicyOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/IntraNodeVisibilityConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/Jwk.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/KubernetesDashboard.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/LegacyAbac.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListClustersRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListClustersRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListClustersResponse.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListNodePoolsRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListNodePoolsRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListNodePoolsResponse.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListOperationsRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListOperationsRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListOperationsResponse.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListUsableSubnetworksRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ListUsableSubnetworksResponse.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/MaintenancePolicy.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/MaintenanceWindow.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/MasterAuth.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/MasterAuthOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/MasterAuthorizedNetworksConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/MaxPodsConstraint.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NetworkConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NetworkPolicy.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NetworkPolicyConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NodeConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NodeManagement.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NodePool.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NodePoolAutoscaling.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NodePoolOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/NodeTaint.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/Operation.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/OperationOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/OperationProgress.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/PrivateClusterConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/PrivateClusterMasterGlobalAccessConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/RecurringTimeWindow.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ReleaseChannel.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ReservationAffinity.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ResourceLimit.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ResourceUsageExportConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/RollbackNodePoolUpgradeRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/RollbackNodePoolUpgradeRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SandboxConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ServerConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetAddonsConfigRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetAddonsConfigRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLabelsRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLabelsRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLegacyAbacRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLegacyAbacRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLocationsRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLocationsRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLoggingServiceRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetLoggingServiceRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetMaintenancePolicyRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetMasterAuthRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetMasterAuthRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetMonitoringServiceRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetMonitoringServiceRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNetworkPolicyRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNetworkPolicyRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNodePoolAutoscalingRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNodePoolAutoscalingRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNodePoolManagementRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNodePoolManagementRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNodePoolSizeRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/SetNodePoolSizeRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ShieldedInstanceConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/ShieldedNodes.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/StartIPRotationRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/StartIPRotationRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/StatusCondition.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/StatusConditionOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/TimeWindow.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UpdateClusterRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UpdateClusterRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UpdateMasterRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UpdateMasterRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UpdateNodePoolRequest.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UpdateNodePoolRequestOrBuilder.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UsableSubnetwork.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/UsableSubnetworkSecondaryRange.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/VerticalPodAutoscaling.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/WorkloadIdentityConfig.java
  • proto-google-cloud-container-v1/src/main/java/com/google/container/v1/WorkloadMetadataConfig.java

@mpeddada1 mpeddada1 requested a review from suztomo October 11, 2022 20:23
@mpeddada1
Copy link
Contributor Author

Compilation error:

 /home/runner/work/java-container/java-container/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java:[64,5] cannot find symbol
Error:    symbol:   variable Util
Error:    location: class com.google.cloud.container.v1.it.ITSystemTest

@mpeddada1
Copy link
Contributor Author

Util.java is present in the 2.3.x branch as well as the main branch

@suztomo
Copy link
Member

suztomo commented Oct 11, 2022

It seems the script doesn't take the hand-written library into account. Can you bring back the Util.java (git checkout 2.3.x -- google-cloud-container/src/test/java/com/google/cloud/container/v1/it/Util.java )?

@mpeddada1
Copy link
Contributor Author

Thank you, yup bringing it back.

@mpeddada1
Copy link
Contributor Author

Tests are passing now

@mpeddada1
Copy link
Contributor Author

The native image job failures are expected for this PR since this branch is older than the one that contains the native image configurations/fixes.

@mpeddada1 mpeddada1 merged commit 27c9f9e into 2.3.x Oct 12, 2022
@mpeddada1 mpeddada1 deleted the 2.3.x_patch branch October 12, 2022 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: container Issues related to the googleapis/java-container API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants